Add support for relx config file #2435
Conversation
src/rebar_relx.erl
Outdated
| ConfigFile = proplists:get_value(config, Options, []), | ||
| case ConfigFile of | ||
| "" -> | ||
| case {rebar_state:get(State, relx, []), file:consult("relx.config")} of |
There was a problem hiding this comment.
We may want to use filename:join([rebar_dir:root_dir(State), "relx.config"]) since we allow changing the base context of where things run.
There was a problem hiding this comment.
Should this also affect --config flag? I didn't implement that.
There was a problem hiding this comment.
Fixed in 7884a4b
src/rebar_relx.erl
Outdated
| ?DEBUG("Using relx.config", []), | ||
| Config; | ||
| {Config, {error, enoent}} -> | ||
| ?DEBUG("Using relx config from rebar.config", []), |
There was a problem hiding this comment.
Configuring releases with the {relx, ...} entry from rebar.config
There was a problem hiding this comment.
Fixed in 96d61cf
src/rebar_relx.erl
Outdated
| "" -> | ||
| case {rebar_state:get(State, relx, []), file:consult("relx.config")} of | ||
| {[], {ok, Config}} -> | ||
| ?DEBUG("Using relx.config", []), |
There was a problem hiding this comment.
Configuring releases with relx.config
There was a problem hiding this comment.
Fixed in 96d61cf
src/rebar_relx.erl
Outdated
| ConfigFile -> | ||
| case file:consult(ConfigFile) of | ||
| {ok, Config} -> | ||
| ?DEBUG("Using relx config file: ~p", [ConfigFile]), |
There was a problem hiding this comment.
same formatting here. Might want to use ~ts for the output of the file though, so we show the string as-is and in unicode-aware text
There was a problem hiding this comment.
Fixed in 96d61cf
This PR adds support for reading the relx configuration from a file when generating a release.
Rebar will continue to use the
rebar.configrelx section as the preferred source of truth, but if there is no such section it will use the configuration from default filerelx.config.However if the
--configflag specifies a configuration file it will be preferred over of the configuration fromrebar.configorrelx.config.I've added a test that should cover these different scenarios.