Update references to changed API elements #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
requested changes
Oct 15, 2020
paulo-ferraz-oliveira
force-pushed
the
unfeature/pkgs
branch
from
68b2039 to
ec402f6
Compare
|
I performed the fixes you asked for. This was such a detailed PR review that I felt I did nothing. And you spent as much time as you would doing that stuff yourself. 😄 Here's to something juicy, in the future... |
ferd
approved these changes
Oct 15, 2020
ferd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still waiting on input from #2397 (comment) and #2397 (comment).