-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rebar3 templates check for name clashes #2384
Make rebar3 templates check for name clashes #2384
Conversation
The CI is failing because I messed up with the conditional definition of the
|
Would it be simpler to translate the name to an atom then calling |
Yes, it would be! Why didn't I think of doing that? Thanks for the suggestion @ferd, I'll commit the changes later |
This commit changes rebar3 to check for name clashes of the modules created from its templates with existing Erlang modules to produce a non-blocking warning for each clashing module.
96fed13
to
9a9f2d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small change to make it safest
Co-authored-by: Fred Hebert <[email protected]>
Got it |
@ferd Windows CI crashed while installing Erlang. Can you restart the whole thing? :) |
yep I'm watching it |
This commit changes rebar3 to check for name clashes of the
modules created from its templates with existing Erlang modules
to produce a non-blocking warning for each clashing module.
It does so by checking if any of the modules that will be created
is already defined in the path and, to do so, reimplements the function
code:all_available/0
when rebar3 is used with a version of Erlang/OTPolder than 23.0, as said function was added in that release.
Should close #1386.