output relative paths in dialyzer provider #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
Sep 12, 2020
src/rebar_file_utils.erl
Outdated
Comment on lines
520
to
537
| %% returns the path for printing to logs. if get_cwd succeeds it | ||
| %% attempts to return the relative path. It falls back on juts | ||
| %% returning the original path. | ||
| print_path(OriginalPath) -> | ||
| case file:get_cwd() of | ||
| {ok, Cwd} -> | ||
| case path_from_ancestor(OriginalPath, Cwd) of | ||
| {ok, ""} -> | ||
| OriginalPath; | ||
| {ok, Path} -> | ||
| Path; | ||
| _ -> | ||
| OriginalPath | ||
| end; | ||
| _ -> | ||
| OriginalPath | ||
| end. | ||
|
|
There was a problem hiding this comment.
rebar_dir already contains format_source_file_name/2; it requires 'opts' but supports compiler_source_format options from the compiler.
We should make a 1-arity wrapper that sends in empty opts and reuse it.
tsloughter
force-pushed
the
dialyzer-rel-path
branch
from
40ad933 to
24ac3d1
Compare
ferd
reviewed
Sep 14, 2020
ferd
reviewed
Sep 14, 2020
tsloughter
force-pushed
the
dialyzer-rel-path
branch
from
964dde9 to
551bd9d
Compare
tsloughter
force-pushed
the
dialyzer-rel-path
branch
from
551bd9d to
e20930a
Compare
ferd
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot I did this. Was going to wait until I updated all of the cases of files being output but meh..