Fix use of ct on projects without CT suites and configuration
#2299
Conversation
Before, running `rebar3 ct` on such an empty project would crash with an internal badmatch since no directory to run CT on could be found. Now this case will terminate with a sensible error message and won't try to run any further.
|
I haven't fixed the tests yet, because I would like input whether the approach is correct. An alternative would be to let |
|
The cleanest way to go would probably to give a success result with 0 tests run -- consider the failure to only trigger when tests fail (rather than only call it a success when they all pass). That would match what EUnit currently does, and compose the best with sequences like |
Makes sense and while writing the PR I had the same feeling. Will adapt it. |
| @@ -339,6 +341,16 @@ multi_app_ct_macro(Config) -> | |||
| true = lists:member({d, 'COMMON_TEST'}, ErlOpts) | |||
| end, Apps). | |||
|
|
|||
| no_ct_suite(Config0) -> | |||
There was a problem hiding this comment.
@ferd This test fails currently with {error, interactive_mode} while running the same setup from the command-line succeeds. I haven't found the culprit in the ct provider yet.
There was a problem hiding this comment.
Is this related to https://erlang.org/doc/apps/common_test/run_test_chapter.html#running-the-interactive-shell-mode ? I never managed to make that work properly or get anything to work with it since the instructions were kind of obscure.
It's possible that was failing way before this test case I figure.
There was a problem hiding this comment.
That is the one, although I don't see where the mode gets activated.
There was a problem hiding this comment.
Yeah I don't know. Curious if passing in a specific lack of options triggers the mode implicitly but I don't know why it would not trigger in the command-line vs others.
There was a problem hiding this comment.
Turns out running CT in an existing CT context is internally considered running in interactive mode. This explains why it works standalone. I adapted the test to only ensure that the options are properly set up.
Before, running
rebar3 cton such an empty project would crash with aninternal badmatch since no directory to run CT on could be found.
Now this case will terminate with a sensible error message and won't try
to run any further.