Add powershell script generation option for escriptize on windows; use for rebar3 itself #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferd
reviewed
May 23, 2020
ferd
approved these changes
May 23, 2020
ferd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You must have been expecting this ;)
This adds bootstrap.ps1 and a powershell escriptize wrapper for windows.
rebar.config setting is, for example,
{escript_wrappers_windows, ["cmd", "powershell"]}which will write BOTH .cmd and .ps1.Can be set to both, one, the other, or none at all.
Updated rebar.config to create both.
Updated workflow to make use of ps1 version.