Allow specifying the outdir in bare compiler #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we just write to ebin/ in the current working directory; this implies that the source _should_ always be in the same subpath as the ebin/ directory. In the cases of utils like Mix, which store downloaded dependencies in deps/ and artifacts in _build/, this may force more rebuild or less caching that would be ideal. This PR adds --outdir / -o as options to the bare compiler, which lets the user specify another path, with a default kept to $CWD.
ferd
force-pushed
the
allow-bare-compile-outdir
branch
from
0c73a84 to
eda264a
Compare
tsloughter
approved these changes
Feb 27, 2020
tsloughter
added a commit
that referenced
this pull request
Feb 28, 2020
Allow specifying the outdir in bare compiler
tsloughter
added a commit
that referenced
this pull request
Feb 28, 2020
Allow specifying the outdir in bare compiler
starbelly
pushed a commit
to starbelly/elixir
that referenced
this pull request
May 12, 2020
rebar3 as of 3.13.2 now supports a --output directory option which allows mix going forward to use said option and put build artifacts in _build which should result and less rebuilding of artifacts and/or better caching of artifacts. Details here: erlang/rebar3#2237 In order to make use of said feature we must put a variable in the system's environment that shall hold the desired output path. rebar3 will recognize said environment variable going forward starting at version 3.14 (yet to be released). - Updated Mix.Tasks.Deps.Compile to put REBAR_BARE_COMPILER_OUTPUT_DIR in system env with the dependency path as the value for use by rebar3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we just write to ebin/ in the current working directory; this
implies that the source should always be in the same subpath as the
ebin/ directory.
In the cases of utils like Mix, which store downloaded dependencies in
deps/ and artifacts in _build/, this may force more rebuild or less
caching that would be ideal.
This PR adds --outdir / -o as options to the bare compiler, which lets
the user specify another path, with a default kept to $CWD.