Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only write lock file if locks have changed #2232

Merged
merged 3 commits into from
Feb 15, 2020

Conversation

ferd
Copy link
Collaborator

@ferd ferd commented Feb 15, 2020

Supercedes #2214

@ferd ferd merged commit c0d016d into erlang:master Feb 15, 2020
@ferd ferd deleted the tsloughter-lock-file-writes branch February 15, 2020 20:47
@hcs42
Copy link

hcs42 commented Sep 19, 2020

Hi @tsloughter and @ferd,

The vim-erlang-compiler and vim-erlang-omnicomplete projects try to guess whether the project is rebar2 or rebar3 based on the presence of the rebar3.lock file. (Present → rebar3, not present → rebar2.)

This heuristic (which not very robust in any case) stopped working after this PR, since rebar3 compile no longer generates rebar.lock file for projects without dependencies.

Do you have a suggestion for a better way to decide if the current project is rebar2 or rebar3?

@ferd
Copy link
Collaborator Author

ferd commented Sep 19, 2020

This is already fixed in master, next point release should be fine.

@hcs42
Copy link

hcs42 commented Sep 19, 2020

Thanks! For future reference: PR #2353 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants