Use double quotes in git shell command on Windows #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts commit f52a115 Fixes erlang#2003 Needs tests to prevent a future regression.
|
well that's an interesting case. This breaks paths with ! on linux, but makes things work on windows... Alright. |
|
There's already a conditional that tests for operating system, and I only changed the windows command, so there shouldn't be any side effects in Linux. |
|
Ah yeah good point, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts commit f52a115
Fixes #2003. (The single quotes cause the path to be mis-parsed in the windows command prompt, git cannot find the repo, and therefore rebar reports that "Locking of git dependency failed".)
Needs tests to prevent a future regression. (Sorry, this is outside my expertise / time available.)