Update hex_core and add mirror_of repo config #1986
Conversation
ericmj
force-pushed
the
emj/mirror-of
branch
from
08738f6
to
a85c4ca
Compare
|
PR updated and hex_core updated hexpm/hex_core#51. |
ericmj
force-pushed
the
emj/mirror-of
branch
5 times, most recently
from
a60acdd
to
c88f5d5
Compare
ericmj
force-pushed
the
emj/mirror-of
branch
from
c88f5d5
to
6a5ad07
Compare
|
This is ready for review. |
|
@ericmj we got a regression from this patch where we used to display: |
| _ = insert_releases(Name, Releases, Repo, ?PACKAGE_TABLE), | ||
| {ok, RegistryDir} = rebar_packages:registry_dir(State), | ||
| PackageIndex = filename:join(RegistryDir, ?INDEX_FILE), | ||
| ok = ets:tab2file(?PACKAGE_TABLE, PackageIndex); | ||
| {ok, {403, _Headers, <<>>}} -> | ||
| {ok, {403, _Headers, _}} -> |
There was a problem hiding this comment.
This is the change that now eats up the warning on line 249/252
Seems the warning was accidentally in place. Maybe we should duplicate it up here.
There was a problem hiding this comment.
I made this change because it's not meaningful to match on an empty body on 403 responses, in fact repo.hex.pm never returns an empty body for 403. Maybe the clause should be removed instead?
No description provided.