Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-expose download/3 for backwards compatibility in git deps related plugins #1976

Merged
merged 8 commits into from
Dec 18, 2018

Conversation

stuart-thackray
Copy link
Contributor

@stuart-thackray stuart-thackray commented Dec 11, 2018

PR for issue described in #1974

Tested with a custom copy of tidy deps and works as expected.

Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a comment on both functions saying they are for backwards compatibility

@ferd ferd changed the title Tidy dep export export download/3 required re-expose download/3 for backwards compatibility in git deps related plugins Dec 18, 2018
@ferd ferd merged commit 06f4b7e into erlang:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants