Fix path coverage loading artifacts #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old path handling routine would force loading a bunch of applications, but it did not necessarily unload them aside from specific calls that the other test handlers used to need to do, but no longer needed under the updated path management of 3.7.0. The leftover calls in the cover compilation bits caused some apps to be loaded and to remain loaded before tests started.
ferd
force-pushed
the
fix-cover-paths
branch
from
c62906a to
d0cc8e5
Compare
ferd
commented
Nov 26, 2018
| @@ -343,7 +343,6 @@ cover_compile(State, Dirs) -> | |||
| ?WARN("Directory ~p error ~p", [Dir, Reason]) | |||
| end | |||
| end, Dirs), | |||
| rebar_utils:cleanup_code_path(rebar_state:code_paths(State, default)), | |||
There was a problem hiding this comment.
Dropped this one because we no longer remove loaded deps, we only set preferential paths. And since cover compilation is done with deps and not plugins, there's no need to put plugins back at the head of the path anymore
tsloughter
approved these changes
Nov 26, 2018
|
Tested and fixes my issue #1958 |
|
Thanks for the confirmation. I'll get the OSX CI to pass (some messed up image download) and merge it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old path handling routine would force loading a bunch of
applications, but it did not necessarily unload them aside from specific
calls that the other test handlers used to need to do, but no longer
needed under the updated path management of 3.7.0.
The leftover calls in the cover compilation bits caused some apps to be
loaded and to remain loaded before tests started.
Fixes #1958