check last modified time on erl files for xrl and yrl files before compiling #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
force-pushed
the
xrl-yrl-recompile
branch
from
05494c4 to
8d31d55
Compare
ferd
reviewed
Nov 9, 2018
| @@ -3,7 +3,7 @@ | |||
| -behaviour(rebar_compiler). | |||
|
|
|||
| -export([context/1, | |||
| needed_files/3, | |||
| needed_files/4, | |||
There was a problem hiding this comment.
is this a change in custom compilers such as mix and whatnot as well?
There was a problem hiding this comment.
Actually mix doesn't need this. mix is a project builder, not a compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937