Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler behaviour #1893

Merged
merged 5 commits into from
Oct 5, 2018
Merged

compiler behaviour #1893

merged 5 commits into from
Oct 5, 2018

Conversation

tsloughter
Copy link
Collaborator

Currently a mess, but want to start getting feed back as early as possible. And since all tests pass I figured I'd open now. will try to at least clean up the api tomorrow (callback specs and actual functions don't match because I'm letting it evolve as I see what is needed by each type of compiler, xrl, yrl, mib, erl).

@tsloughter tsloughter force-pushed the compile-type branch 5 times, most recently from c1f147b to 8f5089d Compare September 29, 2018 17:00
@tsloughter
Copy link
Collaborator Author

Less of a mess now.

Note about the implementation:

  • dependency graphs for source modules are kept separate for each compiler, cached to <app>/.rebar3/<compiler>/source.dag
  • extra_src_dirs (like test) are still compiled to the directory the source is in and not to ebin but I think we should discuss changing this since the modules list in the .app is now built only from modules compiled from source files in src_dirs.

@tsloughter tsloughter changed the title wip: compiler behaviour compiler behaviour Sep 29, 2018
@tsloughter
Copy link
Collaborator Author

One thing still to be done in this PR is the config option for compilers.

I want to support setting compilers and resources in rebar.config instead of requiring use of plugins since these will just be module names and so the apps that provide them can be in the normal deps list.

@tsloughter tsloughter merged commit dec4846 into master Oct 5, 2018
@tsloughter tsloughter deleted the compile-type branch January 2, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants