support for hex v2, multiple repository fetching, private organizations #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before doing that (and reviewing), we should:
|
* update to hex_core for hex-v2 repo support This patch adds only single repo hex-v2 support through hex_core. Packages no longer filtered out by buildtool metadata and the package index is updated per-package instead of fetched as one large ets dump. * tell travis to also build hex_core branch
* support list of repos for hex packages
repos are defined under the hex key in rebar configs. They can be
defined at the top level of a project or globally, but not in
profiles and the repos configured in dependencies are also ignored.
Searching for packages involves first checking for a match in the
local repo index cache, in the order repos are defined. If not found
each repo is checked through the hex api for any known versions of
the package and the first repo with a version that fits the constraint
is used.
* add {repos, replace, []} for overriding the global & default repos
auth token are kept in a hex.config file that is modified by the rebar3 hex plugin. Repo names that have a : separating a parent and child are considered organizations. The parent repo's auth will be included with the child. So an organization named hexpm:rebar3_test will include any hexpm auth tokens found in the rebar3_test organization's configuration.
* move packages to top level of of hexpm cache dir * append organization name to parent's repo_url when parsing repos
* only eval config scripts and apply overrides once per app * move new resource behaviour to rebar_resource_v2 and keep v1 * cleanup use of rebar_resource module and unused functions
* use hex_core tarball unpacking support in pkg resource * ignore etag if package doesn't exist and delete if checksum fails * add back tests for bad package checksums * improve bad registry checksum error message
|
Ok, I"ve rebased on master. |
ferd
approved these changes
Sep 13, 2018
| @@ -103,7 +103,7 @@ run(RawArgs) -> | |||
| case erlang:system_info(version) of | |||
| "6.1" -> | |||
| ?WARN("Due to a filelib bug in Erlang 17.1 it is recommended" | |||
| "you update to a newer release.", []); | |||
| "you update to a newer release.", []); | |||
There was a problem hiding this comment.
space missing in the string, we'll get it is recommendedyou update
| @@ -139,8 +139,14 @@ run_aux(State, RawArgs) -> | |||
| rebar_state:set(State1, rebar_packages_cdn, CDN) | |||
| end, | |||
|
|
|||
| %% TODO: this means use of REBAR_PROFILE=profile will replace the repos with | |||
| %% the repos defined in the profile. But it will not work with `as profile`. | |||
| %% Maybe it shouldn't work with either to be consistent? | |||
There was a problem hiding this comment.
I now think it might make sense not to change the repos, if only to be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly cleaned up commit history of the hex_core branch.
I'd like to get an
-rc1out and that should probably be from master, so I'm opening this PR now.