cover: Fix a race condition in how the server is started as part of a call #9124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call
[Why]
Before sending a message to the cover server, the `call` function checks
if the server is running, starting it if it does not.
However, there is no locking/atomicity between the check and the start.
If there is a concurrent call, the server might be started in parallel
by another process and the `start()` call would return
`{already_started, _}`. This causes the function to fail with the
`badmatch` exception.
[How]
The code now accepts that the server is running after seeing the server
as stopped and retrying the call.
CT Test Results 2 files 22 suites 6m 6s ⏱️ Results for commit 9587c7a. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Before sending a message to the cover server, the
callfunction checks if the server is running, starting it if it does not.However, there is no locking/atomicity between the check and the start. If there is a concurrent call, the server might be started in parallel by another process and the
start()call would return{already_started, _}. This causes the function to fail with thebadmatchexception.How
The code now accepts that the server is running after seeing the server as stopped and retrying the call.