Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common_test: abort_if_missing_suites defaults to true #9045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common_test: abort_if_missing_suites defaults to true #9045

wants to merge 1 commit into from

Conversation

u3s
Copy link
Contributor

@u3s u3s commented Nov 12, 2024

No description provided.

@u3s u3s added the team:PS Assigned to OTP team PS label Nov 12, 2024
@u3s u3s self-assigned this Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

CT Test Results

  2 files   57 suites   1h 15m 49s ⏱️
448 tests 435 ✅ 13 💤 0 ❌
482 runs  466 ✅ 16 💤 0 ❌

Results for commit 5209c92.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s requested review from dgud and IngelaAndin November 12, 2024 13:19
dgud
dgud previously approved these changes Nov 12, 2024
View reviewed changes
@u3s u3s force-pushed the kuba/common_test/abort_if_missing_suites_default_true/OTP-19355 branch from a8612ed to 051db45 Compare November 14, 2024 09:54
@u3s u3s requested a review from dgud November 14, 2024 12:18
u3s
u3s commented Nov 15, 2024
View reviewed changes
lib/common_test/test/ct_surefire_SUITE_data/skip_all_surefire_SUITE.erl Outdated
@@ -0,0 +1,57 @@
%%--------------------------------------------------------------------
%% %CopyrightBegin%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove that test suite. rename existing suite for skipping (generalize it).
adjust test specs accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this turned out to be more tricky. test suite names are used for defining expected events during verification.
when reusing existing test suite I got a conflict and test failures ...

@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Nov 15, 2024
@u3s u3s force-pushed the kuba/common_test/abort_if_missing_suites_default_true/OTP-19355 branch from 051db45 to 1445352 Compare November 25, 2024 07:05
@u3s u3s removed the testing currently being tested, tag is used by OTP internal CI label Nov 25, 2024
@u3s u3s force-pushed the kuba/common_test/abort_if_missing_suites_default_true/OTP-19355 branch from 051db45 to 792669d Compare November 25, 2024 19:43
@u3s u3s force-pushed the kuba/common_test/abort_if_missing_suites_default_true/OTP-19355 branch from 792669d to 5209c92 Compare November 26, 2024 17:01
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngelaAndin IngelaAndin Awaiting requested review from IngelaAndin

@dgud dgud Awaiting requested review from dgud

At least 1 approving review is required to merge this pull request.

Assignees

@u3s u3s

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u3s @dgud