disksup: Support Unicode directories in get_disk_info/1#10721
Open
the-mikedavis wants to merge 1 commit intoerlang:masterfrom
Open
disksup: Support Unicode directories in get_disk_info/1#10721the-mikedavis wants to merge 1 commit intoerlang:masterfrom
get_disk_info/1#10721the-mikedavis wants to merge 1 commit intoerlang:masterfrom
Conversation
Previously, attempting `disksup:get_disk_info/1` with a directory name containing non-ASCII Unicode code points failed on systems where `df` is used because the format specifier for the `df` command uses `~s` rather than `~ts`. We can format with `~ts` and pass the data to the port command as a binary instead.
Contributor
CT Test Results 2 files 15 suites 3m 36s ⏱️ Results for commit 09680b0. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
added
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, attempting
disksup:get_disk_info/1with a directory name containing non-ASCII Unicode code points failed on systems wheredfis used because the format specifier for thedfcommand uses~srather than~ts. We can format with~tsand pass the data to the port command as a binary instead.dfhandles non-ASCII directory names correctly in my testing on Linux.