Provide elvis_path option #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define-null
force-pushed
the
defnull/elvis_path
branch
from
dcaa765
to
37c81a0
Compare
robertoaloi
reviewed
Jan 8, 2021
src/els_config.erl
Outdated
| @@ -99,6 +100,7 @@ do_initialize(RootUri, Capabilities, {ConfigPath, Config}) -> | |||
| CodeReload = maps:get("code_reload", Config, disabled), | |||
| Runtime = maps:get("runtime", Config, #{}), | |||
| CtRunTest = maps:get("ct-run-test", Config, #{}), | |||
| ElvisPath = maps:get("elvis_path", Config, undefined), | |||
There was a problem hiding this comment.
This maybe interpreted as the path to the elvis executable/escript. Would elvis_config_path be a more precise name?
There was a problem hiding this comment.
Good point, fixed.
define-null
force-pushed
the
defnull/elvis_path
branch
from
37c81a0
to
121349e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option for configuring elvis config path