Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused includes/macros (as identified by ELP) #1499

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Cleanup unused includes/macros (as identified by ELP) #1499

merged 3 commits into from
Feb 23, 2024

Conversation

robertoaloi
Copy link
Member

Description

This is the result of running:

elp lint --diagnostic-filter W0020 --apply-fix --in-place
elp lint --diagnostic-filter unused_macro --apply-fix --in-place

@@ -38,7 +38,6 @@
%%==============================================================================
%% Macro Definitions
%%==============================================================================
-define(SERVER, ?MODULE).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the code to use ?SERVER.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, fixed.

@plux
Copy link
Contributor

plux commented Feb 21, 2024

Good stuff! 👍

@plux plux merged commit 88a1adb into main Feb 23, 2024
11 of 12 checks passed
@plux plux deleted the elp-lint branch February 23, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants