Run edoc chunk generation in spawned process #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc chunk generation can be very slow, this would cause completion to hang until finished. Instead return after 1 second. Add check to only generate doc chunks if the chunkfile is missing or not up to date.
plux
force-pushed
the
docs-in-background
branch
from
e396ac0
to
3aefd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc chunk generation can be very slow, this would cause completion to hang until finished.
Instead we now spawn a process and return after 1 second if it generation hasn't completed.
Add check to only generate doc chunks if the chunk file is missing or not up to date.