Improve macro refs performance #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use index to find references instead of traversing all files that includes a header.
plux
force-pushed
the
improve-macro-refs-performance
branch
5 times, most recently
from
64fca3c
to
abed698
Compare
Finding scoped references can be done in two ways:
* Naive, find all POIs that can reach our POI and matches the id.
* Indexed, use the index to find all matching POIs, then check if
they actually reference our POI by using goto_definition.
It varies from case to case which is the fastest, so we race both
functions to get the quickest answer.
plux
force-pushed
the
improve-macro-refs-performance
branch
from
abed698
to
9658f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve performance of looking up references to macros/records.
Finding scoped references can be done in two ways:
Naive, find all POIs that can reach our POI and matches the id.
Indexed, use the index to find all matching POIs, then check if
they actually reference our POI by using goto_definition.
It varies from case to case which is the fastest, so we race both
functions to get the quickest answer.
Fixes #1309.