Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows custom setting the formatter #1473

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

lafirest
Copy link
Contributor

@lafirest lafirest commented Jan 7, 2024

Description

The low-level formatting plugin erlang_ls relies on supports some formatters, maybe it would be good to expose them into the configuration.

This PR added a new configuration section with an option to specify the formatter

Fixes # .

@plux
Copy link
Contributor

plux commented Jan 8, 2024

Thanks for your contribution, @lafirest .

Ironically CI complained about code formatting. :)
You can fix this by running rebar3 fmt and committing the changes.

@lafirest
Copy link
Contributor Author

lafirest commented Jan 8, 2024

Thanks for your contribution, @lafirest .

Ironically CI complained about code formatting. :) You can fix this by running rebar3 fmt and committing the changes.

Sorry, I thought I have formatted, I have fixed this

@plux
Copy link
Contributor

plux commented Jan 8, 2024

Thanks for your contribution @lafirest !

@plux plux merged commit 9696858 into erlang-ls:main Jan 8, 2024
3 of 6 checks passed
@lafirest lafirest deleted the feat/custom_formatter branch January 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants