Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goto definition for implemented behaviour callbacks #1463

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

fridayy
Copy link
Contributor

@fridayy fridayy commented Nov 19, 2023

Description

Currently erlang_ls supports navigation from a behaviour callback to its implementation. It is not possible to navigate back from the implementation to the definition to the callback using goto definition. This PR adds this support.

Looking forward hearing some feedback on this. Have a nice day!

@fridayy
Copy link
Contributor Author

fridayy commented Dec 9, 2023

Hi,
although I haven't touched apps/els_core/src/els_dodger.erl shall I run the formatter and fix this?

edit: the file seems to be properly formatted:

❯ rebar3 fmt -c apps/els_core/src/els_dodger.erl
Checking formatting...
All matched files use erlfmt code style!

@fridayy
Copy link
Contributor Author

fridayy commented Dec 17, 2023

Used erlfmt 1.2.0 locally but CI already runs with v.1.3.0. That's the issue. The file should be properly formatted now.
TIL: Update local plugins regularly

Copy link
Contributor

@plux plux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Nice idea, code looks good!

@plux plux merged commit b2b9945 into erlang-ls:main Dec 20, 2023
5 checks passed
shuying2244 pushed a commit to shuying2244/erlang_ls that referenced this pull request Dec 30, 2023
* Add goto definition for implemented behaviour callbacks
* Format els_dodger with erlfmt 1.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants