[LSP] Fix initialize on OTP 23.0/23.1 #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`els_uri:path/2` was calling `uri_string:percent_decode/1`, which is unavailable until OTP 23.2 (https://www.erlang.org/doc/man/uri_string#percent_decode-1)
|
Hi @danielfinke and thanks for this. It seems the OTP 23 CI still breaks on a XRef error. |
Suppress undefined and deprecated function warnings for calls in `els_uri:percent_decode/1`
|
@robertoaloi I think I have addressed the xref error (as well as a Dialyzer warning when on OTP 23.0/23.1) |
|
Thanks for your contribution @danielfinke ! |
shuying2244
pushed a commit
to shuying2244/erlang_ls
that referenced
this pull request
Dec 30, 2023
* [LSP] Fix initialize on OTP 23.0/23.1 `els_uri:path/2` was calling `uri_string:percent_decode/1`, which is unavailable until OTP 23.2 (https://www.erlang.org/doc/man/uri_string#percent_decode-1) * [LSP] Add Dialyzer/xref ignores Suppress undefined and deprecated function warnings for calls in `els_uri:percent_decode/1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
els_uri:path/2was callinguri_string:percent_decode/1, which is unavailable until OTP 23.2(https://www.erlang.org/doc/man/uri_string#percent_decode-1)