[DAP] Ensure breakpoints are purged on setBreakpoints #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertoaloi
force-pushed
the
correcly-remove-stale-breakpoints
branch
2 times, most recently
from
a79a66a
to
31f3b7a
Compare
robertoaloi
force-pushed
the
correcly-remove-stale-breakpoints
branch
from
31f3b7a
to
b82ef2d
Compare
zengjinc
pushed a commit
to zengjinc/erlang_ls
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a workaround for a bug in the OTP interpreter, which causes breakpoints to stay active, even after they are removed by the user via the UI, for existing processes.
This makes removing breakpoints a very confusing experience, especially in presence of recursive functions, where the only option left to the user is to interrupt and restart the debugging session.
In this PR:
setBreakpointscall