Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAP] Use cwd from launch config, not from project node #1433

Merged
merged 1 commit into from
May 26, 2023

Conversation

robertoaloi
Copy link
Member

@robertoaloi robertoaloi commented May 26, 2023

Description

  • When extracting the file path in the file_from_module_info function, use cwd from launch config, not the one from the project node (that could be started in a different dir)
  • When checking for existence of relative paths, ensure you use the correct cwd

The test suite fix is unrelated and connected to a recent fix in OTP 25.3.

@robertoaloi robertoaloi force-pushed the dap-use-cwd-from-launch-config branch from ad007ef to 2bb8c48 Compare May 26, 2023 12:56
@robertoaloi robertoaloi force-pushed the dap-use-cwd-from-launch-config branch from 2bb8c48 to 375d28f Compare May 26, 2023 14:26
@robertoaloi robertoaloi marked this pull request as ready for review May 26, 2023 14:52
@alanz
Copy link
Contributor

alanz commented May 26, 2023

LGTM

@robertoaloi robertoaloi merged commit 47cefbb into main May 26, 2023
@robertoaloi robertoaloi deleted the dap-use-cwd-from-launch-config branch May 26, 2023 15:33
zengjinc pushed a commit to zengjinc/erlang_ls that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants