Add docs memoization #1417
Merged
Add docs memoization #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed dialyzer checks on older OTP. |
|
Hi @jdamanalo , thanks for submitting this PR and sorry for the long response time. Could you please rebase on main and resolve the conflicts? Thank you! |
|
Thanks for your contribution @jdamanalo ! Seems like CI is a bit salty, I will merge this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1208, and a little more. Since the memoization is done in
els_docs, the change should also helpels_signature_help_providerandels_completion_provider. Should tests be written here for the integration with the 2?Also, there is a slight difference between this PR and #1208 in that there is a small amount of time when the memoization can be cancelled. I wasn't able to think of a solution without changing
els_background_job.