[#1337] Make goto variable definition respect list comprehension scopes #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plux
commented
Nov 8, 2022
| ] | ||
| } | ||
| }, | ||
| %% four: FIXME: Bug, shouldn't rename Var inside second LC |
There was a problem hiding this comment.
Still at least one corner case to fix, leaving that for the future.
plux
force-pushed
the
improve-goto-var-definition-inside-lc
branch
from
a01bdb9
to
353e820
Compare
shuying2244
pushed a commit
to shuying2244/erlang_ls
that referenced
this pull request
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make goto variable definition respect list comprehension scopes.
Fixes #1337 .