Fix performance issue with unused include diagnostics #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused include diagnostic can hog the CPU if there's unreachable include files in combination with huge search path and large source files. The issue boils down to calling file:path_open/3 on the unreachable files for every POI in the source file. To improve the performance memoization on error was added in els_indexing:find_and_deeply_index_file/1 to avoid repeatedly calling file:path_open/3 on the same filename.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unused include diagnostic can hog the CPU if there's unreachable include files in combination with huge search path and large source files.
The issue boils down to calling
file:path_open/3on the unreachable files for every POI in the source file.To improve the performance memoization on error was added in
els_indexing:find_and_deeply_index_file/1to avoid repeatedly callingfile:path_open/3on the same filename.