Show function docs for function_clauses and specs #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`els_docs:docs/2` was not previously implemented for `function_clause` and `spec` POIs, so hover requests would return `null` when hovering over function and spec definitions. This change returns the function definition docs for both cases. The new behavior is in line with other language servers (ElixirLS, rust-analyzer) and can be useful - for example to see how the documentation looks for a function you're just written.
the-mikedavis
force-pushed
the
md-hover-on-definition
branch
from
a1851ea
to
58c2172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
els_docs:docs/2was not previously implemented forfunction_clauseandspecPOIs, so hover requests would returnnullwhen hovering over function and spec definitions. This change returns the function definition docs for both cases.The new behavior is in line with other language servers (ElixirLS, rust-analyzer) and can be useful - for example to see how the documentation looks for a function you're just written.