Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for finding callback implementation for dynamic calls #1328

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add support for finding callback implementation for dynamic calls #1328

merged 1 commit into from
Oct 3, 2022

Conversation

plux
Copy link
Contributor

@plux plux commented Jun 13, 2022

Description

Add support for finding implementation when pointing to a dynamic call that is a behaviour callback.

@plux
Copy link
Contributor Author

plux commented Jun 14, 2022

Again, test failing in CI, but not on my machine -_-

@robertoaloi
Copy link
Member

@plux We need to find the root cause. Filed this one: #1335

@plux plux force-pushed the implementation-dynamic-call branch from f985d08 to 6daeb76 Compare September 20, 2022 18:26
@plux plux force-pushed the implementation-dynamic-call branch from 6daeb76 to a1d138a Compare September 20, 2022 20:19
@plux
Copy link
Contributor Author

plux commented Sep 22, 2022

This is ready to be merged

@robertoaloi robertoaloi merged commit 96b7adb into erlang-ls:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plux @robertoaloi