Do not reload file from disk on save #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of Erlang LS reloads from disk the file on save. Since didSave/didChange methods are notifications (i.e. handled asynchronously by the server), the following race condition could be caused by the sequence: SAVE -> CHANGE -> SAVE Especially in presence of auto-save. While the server is still processing the first SAVE, the version read from disk is the result of the CHANGE being already applied, so the CHANGE operation could fail as invalid. There's actually very little meaning in reloading the file from disk during save, since all changes are sent to the server via CHANGE notifications.
michalmuskala
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of Erlang LS reloads from disk the file on save.
Since didSave/didChange methods are notifications (i.e. handled asynchronously by the server),
the following race condition could be caused by the sequence:
SAVE -> CHANGE -> SAVE
Especially in presence of auto-save.
While the server is still processing the first SAVE, the version read from disk is the result
of the CHANGE being already applied, so the CHANGE operation could fail as invalid.
There's actually very little meaning in reloading the file from disk during save, since all
changes are sent to the server via CHANGE notifications.