Make edoc an optional dependency #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distributions may not include it, and as it's not installed via hex, startup will fail.
|
Hi @filmor and thanks. Won't this causes some runtime errors if the application is not available? If we make the application optional, we should probably ensure those use cases degrade gracefully (eg not to show docs). |
|
It seemed to be doing exactly that (degrading gracefully), but I can check again. |
|
It does seem to degrade half-way gracefully, it doesn't take down all of erlang-ls, just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distributions (like the RabbitMQ Erlang distribution for RHEL/Fedora) may not include it, and as it's not installed via hex, start up will fail.