Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding undefined Function #1267

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

f2000357
Copy link
Contributor

Summary:
This fix supports adding a stub for the undefined function - T112182027

Test Plan:
The commit has a test case in the els_code_action_SUITE

Reviewers:
Roberto Aloi

Subscribers:
Nikita Rubilov

Tasks:
T112182027

Tags:
bootcamp_tasks

Description

Enter a description of your changes here.

Fixes # .

Summary:
This fix supports adding a stub for the undefined function - T112182027

Test Plan:
The commit has a test case in the els_code_action_SUITE

Reviewers:
Roberto Aloi

Subscribers:
Nikita Rubilov

Tasks:
T112182027

Tags:
bootcamp_tasks
Copy link
Contributor

@michalmuskala michalmuskala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, other than that, I think this looks reasonable for the basic functionality

apps/els_lsp/src/els_code_action_provider.erl Outdated Show resolved Hide resolved
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@robertoaloi
Copy link
Member

@f2000357 There are a couple of lint errors in CI:

https://github.com/erlang-ls/erlang_ls/runs/6081908955?check_suite_focus=true

It would be great if you could address those, then we can merge this!

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@robertoaloi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants