Skip indexing of generated files #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the mechanism only supports files tagged as generated via their header. This mechanism can later be expanded based on interest (eg via regex, application, size, etc)
apps/els_lsp/src/els_indexing.erl
Outdated
Comment on lines
53
to
55
| SkipGeneratedFiles = els_config_indexing:get_skip_generated_files(), | ||
| GeneratedFilesTag = els_config_indexing:get_generated_files_tag(), | ||
| try_index_file(Path, 'deep', SkipGeneratedFiles, GeneratedFilesTag), |
There was a problem hiding this comment.
The two values are always passed in together - should they be made into just one accessor? Something like:
els_config_indexing:skip_generated_config()
which would return disabled | {enabled, Tag}
It should simplify the code and follow the "make impossible states unrepresentable" approach
There was a problem hiding this comment.
I like this a lot, but let's do this as a follow up. The main reason is that the whole config management needs refactoring, so it would be nice to come up with a common pattern.
robertoaloi
force-pushed
the
skip-indexing-of-generated-files
branch
from
2ed1070
to
0c34080
Compare
michalmuskala
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.