Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incomplete type definitions better #1237

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Handle incomplete type definitions better #1237

merged 1 commit into from
Mar 8, 2022

Conversation

gomoripeti
Copy link
Contributor

Fixes #1218

@gomoripeti
Copy link
Contributor Author

I changed how the below is interpreted to match epp and erlfmt_parser

-type ?M(A) :: ...
  • this used to be a macro with no args + a type with one arg
  • now this is a macro with one arg

This causes some failing tests, I need to fix.
https://github.com/erlang-ls/erlang_ls/pull/1237/files#diff-cc9d509044808779837f7175898eeab88501b2666fcf925adfc43abc1104d1d5R121-R130

@robertoaloi robertoaloi merged commit dc5ece1 into erlang-ls:main Mar 8, 2022
@robertoaloi
Copy link
Member

LGTM, thanks!

@gomoripeti gomoripeti deleted the incomplete_type branch April 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse error on raw_string
2 participants
@gomoripeti @robertoaloi