Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply quickfix to remove unused macro #1226

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

fangzhzh
Copy link
Contributor

Description

supply quickfix to remove unused macro

Fixes #882

* supply quickfix to remove unused macro
* resolve PR comments

Co-authored-by: zhenfangzhang
Copy link
Member

@robertoaloi robertoaloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! I love how you factored out the "current line" function. Thanks for your contribution!

apps/els_lsp/test/els_code_action_SUITE.erl Show resolved Hide resolved
apps/els_lsp/test/els_code_action_SUITE.erl Outdated Show resolved Hide resolved
@fangzhzh fangzhzh changed the title supply quickfix to remove unused macro (#1) supply quickfix to remove unused macro Feb 24, 2022
@robertoaloi robertoaloi merged commit c544498 into erlang-ls:main Feb 24, 2022
@robertoaloi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Code Action / Quick Fix to remove unused macro
2 participants