Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for goto definition when parsing is incomplete #1224

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

plux
Copy link
Contributor

@plux plux commented Feb 23, 2022

Description

If no POI is matched, try parsing subsets of the text to try to find find a match.
This should improve the user experience when working with unfinished code.

@plux plux force-pushed the goto-definition-incomplete-parsing branch 3 times, most recently from 059da80 to 5752b92 Compare February 23, 2022 17:16
@plux plux force-pushed the goto-definition-incomplete-parsing branch from 5752b92 to 72bd483 Compare February 23, 2022 18:16
apps/els_lsp/src/els_definition_provider.erl Outdated Show resolved Hide resolved
apps/els_lsp/src/els_definition_provider.erl Show resolved Hide resolved
apps/els_lsp/src/els_definition_provider.erl Outdated Show resolved Hide resolved
els_code_actions.erl Outdated Show resolved Hide resolved
@robertoaloi robertoaloi merged commit 0e7814e into erlang-ls:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants