Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle not_found result from docsh #1198

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

keynslug
Copy link
Contributor

Description

Also make sure that functions dealing with temporary group leader here have no chance to get stuck altogether.

Fixes #1177.

Also make sure that functions dealing with temporary group leader
here have no chance to get stuck altogether.

Fixes erlang-ls#1177.
@robertoaloi
Copy link
Member

@garazdawi Do you mind having a look at this one (given you contributed the original code)?

@robertoaloi robertoaloi self-requested a review February 19, 2022 16:14
Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The added timeout in the receive should not be needed, but might as well add it as a safeguard.

@robertoaloi robertoaloi merged commit 45ab202 into erlang-ls:main Mar 21, 2022
@robertoaloi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erlang ls with vscode stops working, uses 100% CPU when vscode is closed
3 participants