Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode output via stdout #1147

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

garazdawi
Copy link
Contributor

@garazdawi garazdawi commented Nov 27, 2021

Fix problem with unicode output to stdout.

While at it also improve rendering of definition lists with code blocks in them.

Closes #1145

We change indent to be " " intead of nbsp as that seems
to be what vscode markdown expects for bullets.
@garazdawi garazdawi changed the title Lukas/fix unicode os cmd Fix unicode output via stdout Nov 27, 2021
@@ -23,7 +23,7 @@ start_listener(Cb) ->
-spec init({function(), atom() | pid()}) -> no_return().
init({Cb, IoDevice}) ->
?LOG_INFO("Starting stdio server..."),
ok = io:setopts(IoDevice, [binary]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@robertoaloi robertoaloi merged commit 210b871 into erlang-ls:main Nov 28, 2021
@robertoaloi
Copy link
Member

Thanks!

@garazdawi garazdawi deleted the lukas/fix-unicode-os-cmd branch November 28, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hovering over os:cmd/1 causes a server crash
2 participants