Parse incomplete text #1146
Merged
Parse incomplete text #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalmuskala Would it be possible to review/merge/release WhatsApp/erlfmt#325 ? Then we wouldn't need to pin the fork for |
robertoaloi
reviewed
Nov 28, 2021
|
This is amazing! It should drastically improve ergonomics while writing new code. |
gomoripeti
commented
Nov 28, 2021
rebar.config
Outdated
| @@ -12,7 +12,8 @@ | |||
| , {docsh, "0.7.2"} | |||
| , {elvis_core, "1.1.1"} | |||
| , {rebar3_format, "0.8.2"} | |||
| , {erlfmt, "1.0.0"} | |||
| %%, {erlfmt, "1.0.0"} | |||
| , {erlfmt, {git, "https://github.com/gomoripeti/erlfmt.git", {branch, "parser_error_loc"}}} %% Temp until PR is merged | |||
There was a problem hiding this comment.
agree, this PR should only be merged after the erlfmt PR
There was a problem hiding this comment.
@gomoripeti If this is the only thing left, should we merge this and bump it as a follow up?
There was a problem hiding this comment.
I should add a hash or tag instead of a branch.
Michal provided some feedback on the PR so my branch might need modifications (and might move)
gomoripeti
force-pushed
the
incomplete
branch
2 times, most recently
from
d83f9e2
to
3967521
Compare
In case of unparsable forms, try removing some trailing tokens, this way the first half of the form could be parsed and POIs extracted. related to erlang-ls#1037
gomoripeti
force-pushed
the
incomplete
branch
from
3967521
to
0811438
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of unparsable forms, try removing some trailing tokens, this way the
first half of the form could be parsed and POIs extracted.
related to #1037