Update erlfmt to 1.0.0 #1113
Merged
Update erlfmt to 1.0.0 #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomoripeti
force-pushed
the
update_erlfmt
branch
from
e334ca5
to
f8e5d44
Compare
robertoaloi
reviewed
Oct 10, 2021
apps/els_lsp/src/els_erlfmt_ast.erl
Outdated
| @@ -507,6 +507,24 @@ erlfmt_to_st(Node) -> | |||
| ), | |||
| Pos | |||
| ); | |||
| {'receive', Pos, {clauses, _PosClauses, ClausList}} -> | |||
There was a problem hiding this comment.
Note: while readingClausList can be easily confused with ClauseList below.
There was a problem hiding this comment.
oops, thanks for catching the typo.
(btw this is the related upstream commit WhatsApp/erlfmt@e532852#diff-bf3e7950ecdf843b8364ae0b189dd89b12d8b374c265f0b04b96d17c86894863)
Change of behaviour: - The record POI now has only a list of atoms in data -> field_list. The default value syntax trees were not used and some memory can be saved this way. - ?MODULE macro as record name also handled for record type (eg go-to-definintion also works from types and specs)
The subtrees function for some node types always skipped record name element, for other types it always included it. This resulted in the inconsistency that sometimes no macro POI was created, in other cases a macro POI was created for ?MODULE macro as well (which would prevent eg. go to definition of the record).
gomoripeti
force-pushed
the
update_erlfmt
branch
from
f8e5d44
to
e375070
Compare
|
Amazing work, thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1097.