[#1047] Mark headers with compiler attributes as used #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomoripeti
approved these changes
Sep 19, 2021
| @@ -120,3 +121,31 @@ inclusion_range(Uri, Document) -> | |||
| _ -> | |||
| #{from => {1, 1}, to => {2, 1}} | |||
| end. | |||
|
|
|||
| %% @doc Given a list of included uris, filter out the ones containing | |||
| %% compiler attributes. If the Uri cannot be found, keep it in the list. | |||
There was a problem hiding this comment.
to me it looks like if lookup_document fails the Uri is filtered out.
There was a problem hiding this comment.
Nice catch. Fixed (the code, not the comment).
robertoaloi
force-pushed
the
1047-mark-headers-with-compiler-attribute-as-used
branch
from
cb6d6e1
to
eae6df9
Compare
robertoaloi
deleted the
1047-mark-headers-with-compiler-attribute-as-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #964 and partially #1047.