Add some sensible defaults if rebar.config is found (#1491)

erlang-ls · Jan 24, 2024 · 63b1839 · 63b1839
1 parent 70efe8f
commit 63b1839
Showing 1 changed file with 40 additions and 3 deletions.
diff --git a/apps/els_core/src/els_config.erl b/apps/els_core/src/els_config.erl
@@ -137,9 +137,11 @@ do_initialize(RootUri, Capabilities, InitOptions, {ConfigPath, Config}) ->
     RootPath = els_utils:to_list(els_uri:path(RootUri)),
     OtpPath = maps:get("otp_path", Config, code:root_dir()),
     ?LOG_INFO("OTP Path: ~p", [OtpPath]),
-    DepsDirs = maps:get("deps_dirs", Config, []),
-    AppsDirs = maps:get("apps_dirs", Config, ["."]),
-    IncludeDirs = maps:get("include_dirs", Config, ["include"]),
+    {DefaultDepsDirs, DefaultAppsDirs, DefaultIncludeDirs} =
+        get_default_dirs(RootPath),
+    DepsDirs = maps:get("deps_dirs", Config, DefaultDepsDirs),
+    AppsDirs = maps:get("apps_dirs", Config, DefaultAppsDirs),
+    IncludeDirs = maps:get("include_dirs", Config, DefaultIncludeDirs),
     ExcludeUnusedIncludes = maps:get("exclude_unused_includes", Config, []),
     Macros = maps:get("macros", Config, []),
     DialyzerPltPath = maps:get("plt_path", Config, undefined),
@@ -278,6 +280,41 @@ do_initialize(RootUri, Capabilities, InitOptions, {ConfigPath, Config}) ->
     ok = set(formatting, Formatting),
     ok.
 
+-spec get_default_dirs(string()) ->
+    {DefaultDepsDirs, DefaultAppsDirs, DefaultIncludeDirs}
+when
+    DefaultDepsDirs :: [string()],
+    DefaultAppsDirs :: [string()],
+    DefaultIncludeDirs :: [string()].
+get_default_dirs(RootPath) ->
+    HasRebarConfig = filelib:is_file(filename:join(RootPath, "rebar.config")),
+    HasErlangMk = filelib:is_file(filename:join(RootPath, "erlang.mk")),
+    case {HasErlangMk, HasRebarConfig} of
+        {false, true} ->
+            ?LOG_INFO("Found rebar.config, using rebar3 default paths."),
+            {
+                _DefaultDepsDirs = [
+                    "_build/default/lib/*",
+                    "_build/test/lib/*"
+                ],
+                _DefaultAppsDirs = ["apps/*", "."],
+                _DefaultIncludeDirs = [
+                    "src",
+                    "include",
+                    "apps",
+                    "apps/*/include",
+                    "_build/*/lib/",
+                    "_build/*/lib/*/include"
+                ]
+            };
+        {_, _} ->
+            {
+                _DefaultDepsDirs = ["deps/*"],
+                _DefaultAppsDirs = ["apps/*", "."],
+                _DefaultIncludeDirs = ["src", "include"]
+            }
+    end.
+
 -spec start_link() -> {ok, pid()}.
 start_link() ->
     gen_server:start_link({local, ?SERVER}, ?MODULE, {}, []).