Include type docs in completion

erlang-ls · Oct 17, 2021 · 3bd8d40 · 3bd8d40
1 parent 15e4086
commit 3bd8d40
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/apps/els_lsp/src/els_completion_provider.erl b/apps/els_lsp/src/els_completion_provider.erl
@@ -88,6 +88,17 @@ resolve(#{ <<"kind">> := ?COMPLETION_ITEM_KIND_FUNCTION
                                    , binary_to_atom(Function, utf8)
                                    , Arity),
   CompletionItem#{documentation => els_markup_content:new(Entries)};
+resolve(#{ <<"kind">> := ?COMPLETION_ITEM_KIND_TYPE_PARAM
+         , <<"data">> := #{ <<"module">> := Module
+                          , <<"type">> := Type
+                          , <<"arity">> := Arity
+                        }
+         } = CompletionItem) ->
+  Entries = els_docs:type_docs('remote'
+          , binary_to_atom(Module, utf8)
+          , binary_to_atom(Type, utf8)
+          , Arity),
+  CompletionItem#{ documentation => els_markup_content:new(Entries) };
 resolve(CompletionItem) ->
   CompletionItem.
 
@@ -511,6 +522,13 @@ resolve_definition(Uri, #{kind := 'function', id := {F, A}} = POI, ArityOnly) ->
           , <<"arity">> => A
           },
   completion_item(POI, Data, ArityOnly);
+resolve_definition(Uri, #{kind := 'type_definition', id := {T, A}} = POI,
+                   ArityOnly) ->
+  Data = #{ <<"module">> => els_uri:module(Uri)
+          , <<"type">> => T
+          , <<"arity">> => A
+          },
+  completion_item(POI, Data, ArityOnly);
 resolve_definition(_Uri, POI, ArityOnly) ->
   completion_item(POI, ArityOnly).