Change swiftdialog to notification (from dialog) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's less intrusive for users with notifications
erikstam
reviewed
Apr 9, 2024
|
I was actually considering that when I created this PR. If I can come up with a good way to implement it without breaking anything, I'll add a commit or two to this PR. |
Default is still a mini dialog, but changing `swiftDialogNotification` to `notification` will use notifications instead. Also added `FallBacktoAS=true` to swiftdialog, since it was missing
|
I've added the possibility to choose notification type with Swift Dialog. Default is reverted a mini dialog, but changing Also added N.B, if you also merge #25 it will be possible to set that argument differently for each label. |
erikstam
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's less intrusive for users with notifications