Update to node 5.x.x addresses Babel 6 issues#936
Merged
quicksnap merged 2 commits intoerikras:masterfrom Feb 20, 2016
andrewmclagan:master
Merged
Update to node 5.x.x addresses Babel 6 issues#936quicksnap merged 2 commits intoerikras:masterfrom andrewmclagan:master
quicksnap merged 2 commits intoerikras:masterfrom
andrewmclagan:master
Conversation
The pull request to update Babel `6.x.x` raises the old `ReferenceError: _ApiClient is not defined` error on fresh installation, with node `4.2.4`. All tests are green and everything seems fine with node `5.6.0`. Think its time to upgrade... Babel 6 plays nicer with 5.x.x anyway. see PR: #935
Contributor
|
Are you sure that it will not work with node version 5 <= x < 5.6.0 ? |
Contributor
|
Btw, I'm already using node v5 through nvm |
Collaborator
Author
|
I'd say it would work with 5.x.x although only tested on 5.6.x |
Collaborator
|
Could you add node 5 to the travis test suite? Let's see if it passes.. |
updated travis test suite to include 5.x.x
Collaborator
Author
|
sure. done |
quicksnap
added a commit
that referenced
this pull request
Feb 20, 2016
Update to node 5.x.x addresses Babel 6 issues
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request to update Babel
6.x.xraises the oldReferenceError: _ApiClient is not definederror on fresh installation, with node4.2.4.All tests are green and everything seems fine with node
5.6.0. Think its time to upgrade... Babel 6 plays nicer with 5.x.x anyway.see PR: #935