Skip to content

Comments

Revert deferred props, updating to redux-async-connect 1.x.x#928

Merged
quicksnap merged 1 commit intoerikras:masterfrom
sars:deferred-props
Feb 17, 2016
Merged

Revert deferred props, updating to redux-async-connect 1.x.x#928
quicksnap merged 1 commit intoerikras:masterfrom
sars:deferred-props

Conversation

@sars
Copy link
Contributor

@sars sars commented Feb 15, 2016

No description provided.

@sars
Copy link
Contributor Author

sars commented Feb 15, 2016

Guys, take a look, please.
This is a try to solve: #872 ,
brocoders/redux-async-connect#9
brocoders/redux-async-connect#16
brocoders/redux-async-connect#18

If you have some suggestions about interface or another solution, it would be great

You can specify key in load async items - in this case corresponding actions will be dispatched.
Otherwise - it just delay rendering until data is loaded.

Also you are able to specify groups of load async items, so can filter them.

quicksnap added a commit that referenced this pull request Feb 17, 2016
Revert deferred props, updating to redux-async-connect 1.x.x
@quicksnap quicksnap merged commit c5fe738 into erikras:master Feb 17, 2016
@quicksnap
Copy link
Collaborator

Thanks!

@kjanoudi
Copy link

Hey @sars, I'm not sure i'm seeing the advantage to using redux-async-connect in the fashion that it's being used in this boilerplate. I still see us using a reducer in the src/redux/modules/widgets.js file, and still see actions being dispatched by there as well.

Could you elaborate on the details of this particular use case? Would you say that some of the features of redux-async-connect are not being taken advantage of in this example? If so, how can it be improved to take full advantage of your package?

Thanks!

@oyeanuj
Copy link

oyeanuj commented Jun 14, 2016

@sars Do you think this PR needs to be updated to redux-connect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants