Repository navigation
Bump the nuget-patch-and-minor group with 7 updates #2336
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,46 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <Nullable>enable</Nullable> | ||
| <ImplicitUsings>disable</ImplicitUsings> | ||
| <RootNamespace>PerformanceMonitor.Darling.Analysis</RootNamespace> | ||
| <AssemblyName>PerformanceMonitor.Darling.Analysis</AssemblyName> | ||
| <Company>Darling Data, LLC</Company> | ||
| <Copyright>Copyright © 2026 Darling Data, LLC</Copyright> | ||
| <EnableNETAnalyzers>true</EnableNETAnalyzers> | ||
| <AnalysisLevel>latest-recommended</AnalysisLevel> | ||
| <NoWarn>CA1849;CA2007;CA1508;CA1822;CA1805;CA1510;CA1816;CA1861;CA1845;CA2201;CA1848;CA1852;CA1305;CA1860;CA1707;CA1507;CA1806;CA2254</NoWarn> | ||
| <WarningsAsErrors>CS4014</WarningsAsErrors> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <!-- The plan fetcher connects to the MONITORED SQL Server (same client the Service uses); | ||
| Npgsql and Logging.Abstractions flow transitively from the Storage/Notifications references. --> | ||
| <PackageReference Include="Microsoft.Data.SqlClient" /> | ||
| <PackageReference Include="ModelContextProtocol" /> | ||
| <PackageReference Include="System.Security.Cryptography.ProtectedData" VersionOverride="10.0.11" /> | ||
|
There was a problem hiding this comment.
It also contradicts the policy documented right at the top of
|
||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\PerformanceMonitor.Analysis\PerformanceMonitor.Analysis.csproj" /> | ||
| <ProjectReference Include="..\..\PerformanceMonitor.Collectors\PerformanceMonitor.Collectors.csproj" /> | ||
| <!-- AlertContextSerializer: the finding store persists/reads remediation_action_json through the | ||
| SAME serializer both apps use, so a Darling finding's action round-trips byte-identically. --> | ||
| <ProjectReference Include="..\..\PerformanceMonitor.Notifications\PerformanceMonitor.Notifications.csproj" /> | ||
| <!-- PlanAdvisoryAggregator: the fact collector's WS4 plan advisories parse collected plan XML | ||
| through the same shared ShowPlanParser/PlanAnalyzer both apps use. --> | ||
| <ProjectReference Include="..\..\PerformanceMonitor.PlanAnalysis\PerformanceMonitor.PlanAnalysis.csproj" /> | ||
| <ProjectReference Include="..\PerformanceMonitor.Darling.Storage\PerformanceMonitor.Darling.Storage.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <InternalsVisibleTo Include="Darling.Tests" /> | ||
| <!-- #2317: the worker's self-metrics catch names a timeout as a timeout via PgBaselineProvider's | ||
| IsCommandTimeout — one definition of the structural predicate, not a copy that drifts. --> | ||
| <InternalsVisibleTo Include="PerformanceMonitor.Darling.Service" /> | ||
| <!-- The viewer's blocking read path reuses PgBlockingPairRowQuery (the shared source-agnostic | ||
| chain reconstructor's Postgres row shaper) directly, mirroring how Lite/Dashboard consume | ||
| the shared blocking internals. --> | ||
| <InternalsVisibleTo Include="PerformanceMonitor.Darling.Viewer" /> | ||
| </ItemGroup> | ||
| </Project> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two references added by dependabot, both worth confirming before merge:
L20 —
<PackageReference Include="ModelContextProtocol" />promotes this project from a transitive MCP consumer to a direct one. The code does use it (PgDrillDownCollector.Plans.cs:103,188—McpHelpers.Truncate), so it isn't wrong, but it's a semantic change dependabot shouldn't be making on its own during a version bump; nothing inAnalysisuses an MCP surface that wouldn't already flow viaPerformanceMonitor.Common. Confirm this is intentional or drop it.L21 —
VersionOverride="10.0.11"matches the central pin atDirectory.Packages.props:29exactly, so it's a no-op that just adds a divergence point for the next bump to forget about. IfAnalysisneeds this package as a direct reference, drop the override and let CPM resolve it (<PackageReference Include="System.Security.Cryptography.ProtectedData" />); if not, drop the reference entirely — it flows in transitively fromStorage/Notificationstoday.Same pattern in
PerformanceMonitor.PlanAnalysis/PerformanceMonitor.PlanAnalysis.csproj:25.Generated by Claude Code